-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SemverJ as Version manager #454
base: master
Are you sure you want to change the base?
Conversation
It's a good PR but for the moment I don't know what to do. |
- added dependency semver4j - added SemverJVersionManager to prevent breaking change for existing users (default implementation is still DefaultVersionManager => explicit opt-in required) - added isStable to VersionManager interface making it easier to only allow snapshots in test environments(DefaultVersionManager returns always true) - added test method for DefaultVersionManager for snapshots - added tests for SemverJVersionManager
…library is named semver4j - renamed the Test class accordingly - made semver4j an optional dependency - updated javadoc of Semver4jVersionManager to make it clear that the semver4j library must be included
0e65894
to
6fc71b1
Compare
I have updated my PR to make the library optional. Another thought - untested yet: What would you think of using the official maven library: the latest version is from april 2021 and we would always be compatible with the maven versioning. From what I have found in the javadoc you can: some example of maven version ranges taken from the javadoc:
|
- added second alternative: MavenVersionManager - added test for MavenVersionManager
I have added maven as alternative VersionManager - have a look and tell me what you think... |
closes #440