Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff false positive on function #1836

Closed
pematt opened this issue Dec 9, 2023 · 2 comments
Closed

Diff false positive on function #1836

pematt opened this issue Dec 9, 2023 · 2 comments
Milestone

Comments

@pematt
Copy link

pematt commented Dec 9, 2023

Bug description
The diff generates a false positive on a function.

How to reproduce
Install the attached model in an empty DB
Perform a diff
This will generate a false positive on function test.test2

Model:
test2.dbm.zip

Expected behavior
Since the function has not been changed then it should not be identified as changed in the diff process.

Info about your desktop

  • OS: Linux Mint
  • Version: 21.1
  • Window manager: default
  • pgModeler version: 1.1.0-beta1
  • Qt version: 6.2.4
@pematt
Copy link
Author

pematt commented Dec 9, 2023

There are also false positives on columns with default value, and there are false positives on sequences with comments.

How to reproduce
Install the attached model in an empty DB
Perform a diff
This will generate false positives for a column and for a sequence comment.

test3.dbm.zip

@rkhaotix rkhaotix added the bug label Apr 10, 2024
@rkhaotix rkhaotix added this to the 1.1.x milestone Apr 10, 2024
@rkhaotix
Copy link
Member

There are also false positives on columns with default value,

See here #1851

and there are false positives on sequences with comments.

Found the problem, the comments of sequences aren't being imported correctly. I'll investigate.

rkhaotix added a commit that referenced this issue Apr 10, 2024
sequences causing false-positive to be generated in diff process (#1836)
@rkhaotix rkhaotix added the fixed label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants