Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify required functions checks in ext/pcntl #14288

Merged
merged 1 commit into from
May 21, 2024

Conversation

petk
Copy link
Member

@petk petk commented May 21, 2024

No description provided.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk petk merged commit 0927651 into php:master May 21, 2024
10 checks passed
@petk petk deleted the patch-simplify-errors branch May 21, 2024 12:53
@petk
Copy link
Member Author

petk commented May 21, 2024

Eh, today is not my day for M4 and Autoconf 😆 I've missed that these are required functions, meaning they don't need to provide HAVE_ symbols anymore... Sorry. I'll get back to this in the upcoming PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants