[FEATURE] POST subscriptions route #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase against master, please @macolu? :) |
macolu
force-pushed
the
post-subscription
branch
from
666e320
to
030325b
Compare
|
@xh3n1 done :) |
|
Confirmed working to add a subscriber to a single list. |
|
I'm not part of the team, so I can't go any further... |
|
@michield Can we look into this? |
you need to clear cache in order to get the new /subscriptions to be recognized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new endpoint to add a member to a list.
Fix #118
Not sure this is the way you would have done it. Anyway, I had to implement it for an urgent need, so here it is :-)
Unit test
Integration tests added.
Code style
No code style errors according to phpcs.
Other Information
Code uses methods on Repositories that are not declared with "@method" annotations.
I can make another PR on Core to add missing annotations if you want.