Fix UnusedLocalVariable to recognize compact function.

[jrbasso]

The test case explain by itself.

[tariquesani]

Thanks - this is what I was looking for. Should be merged ASAP :-)

[ceeram]

+1 for this to be merged

[svscorp]

Hello!

I've downloaded 1.4.1 version, after getting 'UnusedLocalVariable' message in my controller with using compact function. Run phpmd again, and I've got the same message :(

public function foo(){
$id = 1;
return $this->redirect($this->generateUrl('foo.php', compact('id')));
}

Doesn't work...

[ceeram]

@svscorp Strange that it doesnt work for you, with the 1.4.1 release all the warnings in cakephp core are gone for compact() and UnusedLocalVariable

[svscorp]

@ceeram Yes, strange for me too. We use Symfony 2.1

[svscorp]

Should I create a new ticket?

[rakeshtembhurne]

Via @svscorp:
In Symfony 2.1 $func->getImage() returns a string like "Acme/SomethingBundle/compact"
line no. 144, file src/main/php/PHP/PMD/Rule/UnusedLocalVariable.php, code if(strpos($func->getImage(),'compact'))

I am using CakePHP 2.2 and on my machine $func->getImage() returns string "__".