Complete fix for #77 (timezone warning)

[michaelhogg]

The #77 bug involves this warning being raised when PHPMD is executed:

Warning: date(): It is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting or the date_default_timezone_set() function.

In v2.0.0 and earlier, the warning was caused by calling date() without first setting the timezone, in this line in XMLRenderer::renderReport():

$writer->write('timestamp="' . date('c') . '">');

93b5835 attempted to fix the bug by adding this code to src/bin/phpmd:

if (!ini_get('date.timezone') && !date_default_timezone_get()) {
    date_default_timezone_set('UTC');
}

⚠️ Although this fixed the warning from the date() call in XMLRenderer::renderReport(), it introduced a new bug. The new call to date_default_timezone_get() raises this warning:

Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting or the date_default_timezone_set() function.

See @hbandura's comment on #77.

From the docs for date_default_timezone_get():

In order of preference, this function returns the default timezone by:

• Reading the timezone set using the date_default_timezone_set() function (if any)
• Reading the value of the date.timezone ini option (if set)

There's no need to call date_default_timezone_get(), because:

• We know date_default_timezone_set() hasn't been called. (Look at the top of src/bin/phpmd. Only Composer's autoload.php is executed, and date_default_timezone_set() is not called there.)
• We've just tested the value of the date.timezone ini option by calling ini_get('date.timezone').

So the call to date_default_timezone_get() can safely be removed, and this will completely fix the issue of the timezone warning.

[Arcanemagus]

Any chance you can look this over @ravage84?

[ravage84]

@Arcanemagus & @michaelhogg It would be great if you could verify that the dev-master of phpmd now works for you. Thanks

[manuelpichler]

+1

[Arcanemagus]

The changes in this PR fix the messages about the timezone, the rest of my phpmd installation isn't working at the moment though and I have yet to trace that down. (Installed globally via composer on Win 8.1 x64, and I could swear it was working at one point so I'm not sure when it broke.)

[Arcanemagus]

Well, after a reboot it's working perfectly again, go figure.

With the changes from this PR I'm no longer getting error messages about the timezone.