Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language combobox is hard to read #19075

Open
M393 opened this issue Mar 21, 2024 · 3 comments · May be fixed by #19093
Open

Language combobox is hard to read #19075

M393 opened this issue Mar 21, 2024 · 3 comments · May be fixed by #19093
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete

Comments

@M393
Copy link
Contributor

M393 commented Mar 21, 2024

Is your feature request related to a problem? Please describe.

The languages in the combobox are sorted by the English language name, but this name is not horizontally aligned with the other languages. This makes it difficult to find a language.

Describe the solution you'd like

Sort the combobox by the native language name. This name s what I'm looking for, the name of my language in my language.

image

Describe alternatives you've considered

Put the English language name first.
image

Additional context

  • phpMyAdmin version: 5.2.1 / master
    Current state:
    image
@anujeshify
Copy link

anujeshify commented Mar 22, 2024

I'm interested in contributing to this issue. After reviewing the discussion and understanding the problem, I believe I can offer a solution.

@M393
Copy link
Contributor Author

M393 commented Mar 22, 2024

The necessary change is quite small. And I already implemented it locally. (That's how I made the screenshots.)
Just waiting for someone to say they welcome this change.

@anujeshify
Copy link

The necessary change is quite small. And I already implemented it locally. (That's how I made the screenshots.) Just waiting for someone to say they welcome this change.

Thank you for implementing the change locally and for providing screenshots. I'm glad to hear that the necessary modification is relatively small. I've already submitted a pull request addressing the issue based on our discussion. You can find it here.

@M393 M393 linked a pull request Apr 3, 2024 that will close this issue
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants