Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move function to admin-ui-classic-bundle #15971

Open
brusch opened this issue Sep 19, 2023 · 1 comment · May be fixed by pimcore/admin-ui-classic-bundle#457 or #16745
Open

Move function to admin-ui-classic-bundle #15971

brusch opened this issue Sep 19, 2023 · 1 comment · May be fixed by pimcore/admin-ui-classic-bundle#457 or #16745
Assignees
@kingjia90
Labels
Improvement Pimcore:Priority
Milestone
11.3.0

Comments

@brusch
Copy link
Member

brusch commented Sep 19, 2023

Improvement description

pimcore/models/Asset/Service.php

Line 277 in 0fcf252

public static function getPreviewThumbnail(Asset $asset, array $params = [], bool $onlyMethod = false): ?string

doesn't belong to pimcore/pimcore it should be in https://github.com/pimcore/admin-ui-classic-bundle
@brusch brusch added this to the 11.1.0 milestone Sep 19, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Sep 26, 2023

This is called in gridAssetData so that should be moved to admin bundle as well and maybe other element types as well e.g. gridObjectData& gridDocumentData. maybe implement a new service in admin ui bundle.

@dvesh3 dvesh3 modified the milestones: 11.1.0, 11.2.0 Sep 26, 2023
@ibousfiha ibousfiha self-assigned this Feb 20, 2024
@wisconaut wisconaut assigned kingjia90 and unassigned ibousfiha Feb 26, 2024
This was referenced Mar 6, 2024
Open
Draft
@brusch brusch modified the milestones: 11.2.0, 11.3.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingjia90 kingjia90

Labels
Improvement Pimcore:Priority
Projects
None yet
Milestone
11.3.0
5 participants
@brusch @dvesh3 @kingjia90 @ibousfiha @wisconaut