Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Redirect Class should have methods to get safe target path #16896

Open
dweiss96 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #16901
Open

[Improvement]: Redirect Class should have methods to get safe target path #16896

dweiss96 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #16901
Labels
Improvement PR Welcome

Comments

@dweiss96
Copy link

dweiss96 commented Apr 4, 2024

Improvement description

When reading redirects with php code the target can be either a path or a site id. The type of the redirect does not reflect the nature of the target link. With type path it can either be an id or a path string.

Therefore an additional method for getting the actual target path should be added.
@dweiss96 dweiss96 linked a pull request Apr 5, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement PR Welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add target resolution to redirect model dweiss96/pimcore
1 participant
@dweiss96