Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make allowed thumbnail formats case-insensitive #17035

Merged
merged 1 commit into from
May 13, 2024
Merged

Make allowed thumbnail formats case-insensitive #17035

merged 1 commit into from
May 13, 2024

Conversation

markus-moser
Copy link
Contributor

@markus-moser markus-moser commented May 13, 2024 •
edited

Since this commit Pimcore checks if a thumbnail definition provides a valid format:

a6821a1

This is done in a case-sensitive way therefore the Pimcore preview thumbnail config does not work anymore (as there the format is 'PJPEG').

This PR solves this problem in 2 ways:

  1. Change 'PJPEG' to lowercase in the preview thumbnail config.
  2. Make the thumbnail config format check case-insensitive.

@markus-moser markus-moser added this to the 11.3.0 milestone May 13, 2024
@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@markus-moser markus-moser merged commit ecc1ff6 into 11.x May 13, 2024
19 checks passed
@markus-moser markus-moser deleted the preview-config-fix branch May 13, 2024 08:16
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
@markus-moser markus-moser modified the milestones: 11.3.0, 11.2.4 May 13, 2024
@markus-moser
Copy link
Contributor Author

Backported to 11.2.4

@markus-moser markus-moser removed this from the 11.2.4 milestone May 13, 2024
@markus-moser
Copy link
Contributor Author

markus-moser commented May 13, 2024 •
edited

We have a different reason for our problem => reverted in #17036

@markus-moser markus-moser removed the Bug label May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markus-moser