Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary storage usage limitation of total queries. #13983

Closed
SunRunAway opened this issue Dec 9, 2019 · 2 comments · Fixed by #15700
Closed

temporary storage usage limitation of total queries. #13983

SunRunAway opened this issue Dec 9, 2019 · 2 comments · Fixed by #15700
Assignees
@Yisaer
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement
Projects
SIG Runtime Kanban Challenge Program

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Dec 9, 2019 •
edited

Description

In master branch, TiDB can use temporary storage to do hash join,

we need to control the temporary storage usage of total queries to prevent tidb-server consuming all the disk space.

  • If the disk limit is specified, and if the capacity of the temporary directory is smaller than the limit, - fatal when tidb-server starts
  • If the disk limit is unspecified, and if the capacity of the temporary directory is smaller than memory-quota-limit, warn when tidb-server starts

PostgreSQL has a similar configuration, see https://www.postgresql.org/docs/9.3/runtime-config-resource.html#RUNTIME-CONFIG-RESOURCE-DISK

Score

  • 300

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • skills 1
  • skills 1

Learning Materials
@SunRunAway SunRunAway mentioned this issue Dec 9, 2019
Open
14 tasks
@SunRunAway SunRunAway added the sig/execution SIG execution label Dec 9, 2019
@SunRunAway SunRunAway changed the title temporary storage usage limitation of a query. temporary storage usage limitation of total queries. Dec 9, 2019
@SunRunAway SunRunAway added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. difficulty/easy and removed difficulty/easy labels Dec 9, 2019
@zz-jason zz-jason added this to Issue Backlog: Need Triage in SIG Runtime Kanban via automation Mar 14, 2020
@SunRunAway SunRunAway moved this from Issue Backlog: Need Triage to Backlog: Low Priority in SIG Runtime Kanban Mar 16, 2020
@SunRunAway SunRunAway added this to TODO/Easy in Challenge Program via automation Mar 23, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Mar 25, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2020

@Yisaer pick up issue success

@Yisaer Yisaer mentioned this issue Mar 25, 2020
Merged
@SunRunAway SunRunAway moved this from TODO/Easy to TODO/Medium in Challenge Program Mar 26, 2020
@SunRunAway SunRunAway moved this from Backlog: Low Priority to In Progress in SIG Runtime Kanban Apr 2, 2020
Challenge Program automation moved this from TODO/Medium to Issue: DONE Apr 8, 2020
SIG Runtime Kanban automation moved this from In Progress to Done (This Week) Apr 8, 2020
@sre-bot sre-bot mentioned this issue Apr 8, 2020
Merged
@zz-jason zz-jason moved this from Done (This Week) to Done (Historical) in SIG Runtime Kanban Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yisaer Yisaer

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement
Projects
No open projects
Challenge Program
  
Issue: DONE
SIG Runtime Kanban
  
Done (Historical)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: support temporary storage usage limitation Yisaer/tidb
3 participants
@SunRunAway @Yisaer @sre-bot