executor: improve codes of stmt hints #12246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12246 +/- ##
=========================================
Coverage 81.075% 81.075%
=========================================
Files 454 454
Lines 98658 98658
=========================================
Hits 79987 79987
Misses 12899 12899
Partials 5772 5772 |
|
should we cherry pick this pr to release-3.1? |
alivxxx
added
status/LGT2
|
Your auto merge job has been accepted, waiting for 12250, 12225 |
|
/run-all-tests |
|
@foreyes merge failed. |
|
/run-unit-test |
Nope, seems we don't need these hints in 3.1. |
lonng
reviewed
Sep 18, 2019
foreyes
force-pushed
the
dev/improve_stmt_hint
branch
from
44c2a7e
to
a27600a
Compare
|
/run-all-tests |
|
Could you approve again? @lamxTyler |
zz-jason
approved these changes
Sep 18, 2019
|
/merge |
|
Your auto merge job has been accepted, waiting for 12249, 12234 |
Does release 3.1 have this performance issue? |
|
/run-all-tests |
|
@foreyes merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improve codes of #11809
What is changed and how it works?
Reduce function cost when there is no sql hint.
Record last hint instead of save the whole list.
Check List
Tests
Code changes
Side effects
Related changes
Release note