Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix merge cm sketch panic (#13391) #13394

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 12, 2019

cherry-pick #13391 to release-3.0


What problem does this PR solve?

Fast analyze on multi-column indexes will panic when merge cm sketches when there are no samples.

What is changed and how it works?

Check if the cm sketch is nil when merging them.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix panic when fast analyze on multi-column indexes

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 12, 2019

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 12, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 12, 2019

Your auto merge job has been accepted, waiting for 13278, 12729, 13395

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit baba948 into pingcap:release-3.0 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants