Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required fields don't do anything in Java #213

Open
shashachu opened this issue May 29, 2019 · 2 comments
Open

required fields don't do anything in Java #213

shashachu opened this issue May 29, 2019 · 2 comments
Labels

Comments

@shashachu
Copy link
Contributor

They add @NonNull annotations, but otherwise, there's no consequence. If I have a model with a required field, I'd expect that MyModel.builder().build() would throw an exception, but as it is, it allows you to build a model with null required fields.

@rahul-malik
Copy link
Collaborator

I think this seems related to the issue around adding validation methods #185

@shashachu
Copy link
Contributor Author

Haha I'm disagreeing with my past self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants