Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to detect use of outdated Plank binary #236

Open
RicoYao opened this issue Aug 23, 2019 · 3 comments
Open

Make it easier to detect use of outdated Plank binary #236

RicoYao opened this issue Aug 23, 2019 · 3 comments

Comments

@RicoYao
Copy link
Contributor

RicoYao commented Aug 23, 2019

In a codebase where developers manually execute the Plank binary to generate models, it is difficult to detect scenarios where they may be landing code based on an outdated Plank binary.

One possible solution would be to write a Plank version/build number of some kind into the generated model header block so that version control systems (e.g. Git, SVN) can warn developers with merge errors. e.g.

// Autogenerated by Plank (https://pinterest.github.io/plank/)
// Plank v7.32
@RicoYao RicoYao changed the title Make it easier to detect merge conflicts in generated models Make it easier to detect use of outdated Plank binary Aug 23, 2019
@rahul-malik
Copy link
Collaborator

@RicoYao - you can add the version to the generated code, in practice we end up updating the models when there is a new version of plank added to our repository

@RicoYao
Copy link
Contributor Author

RicoYao commented Aug 23, 2019

@rahul-malik

you can add the version to the generated code

Just confirming what you mean by this - are you suggesting that we configure our own scripts to add the version header after Plank generates the models? We can do that.

@rahul-malik
Copy link
Collaborator

I'm just saying that plank can update the file header it generates to output the current version. We have a struct that contains the version that you should be able to utilize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants