New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current frame "jumps" on screen hold in iOS6 with Safari #260
Comments
Interesting. Replicated on iOS5 too, so far seems isolated to Safari only. Chrome on iPad1 works fine. Thank you for making me aware of this! Investigating more... |
…iOS for example), if handler is triggered from by touch it "locks" to it and will ignore any non-touch events including touch-mouse, which will follow. `up` event releases this lock after 30 ticks (<1s) to prevent further `mouseup` event from spoiling the touch interaction. #260
OK, as far as I could tell, this was a rather unpleasant side effect of changes made in #233. Since then both touch* and mouse* events are bound together to allow for devices with both mouse and touch. Before that the binding was conditional on touch feature detection. Evidently this configuration does not work well with tablets where a touch interaction triggers both touch AND mouse event. It causes handlers to be double-triggered and resulting in issues like yours. Now I scrutinize the events and basically suppress mouse events closely following touch events., which resulted in fixed iPad issues and even slightly improved performance. @trecord, Please help me test this fix by grabbing the patched code from gh-260-touch-fix branch and testing on your setup and device. Thanks! |
Hi Petr, I just uploaded the new build and gave it a quick test on an iOS6 device in Safari. I can confirm that it's fixed. |
That was quick! Thank you @trecord |
I've noticed that on my iPad with iOS6 and Safari, reel will often "jump" from the current frame to another far from where the user was if the user presses and "holds"* on the screen. It seems to be specific to iOS6 and earlier: I tried on a device with iOS7, and wasn't able to recreate this issue. I recreated this with reel's demo pages.
*By "hold" I mean touching the screen in an area where reel is active for a second or so without moving your finger.
The text was updated successfully, but these errors were encountered: