Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Interaction enhancements #56

Open
docapotamus opened this issue May 2, 2015 · 9 comments
Open

UI Interaction enhancements #56

docapotamus opened this issue May 2, 2015 · 9 comments
Assignees

Comments

@docapotamus
Copy link
Member

docapotamus commented May 2, 2015

There are parts of the UI that would be much better if they made Ajax style calls for various tasks.

Deleting posts, voting, etc, would all benefit from not changing the flow due to page reloads.

We need to write this in a way that keeps compatibility with text based browsers such as Lynx.

@docapotamus docapotamus added this to the 0.9 milestone May 2, 2015
@docapotamus docapotamus self-assigned this May 2, 2015
@mcrmonkey
Copy link
Member

Probably worth looking in to "dataType" here. We can set this on an ajax style call and when its not present it has the same effect as it does now.

See this for more info and a quick example

@mcrmonkey mcrmonkey changed the title More javascript UI Interaction enhancements May 10, 2015
@docapotamus
Copy link
Member Author

We can just use the built in Flask method for checking this http://flask.pocoo.org/docs/0.10/api/#flask.Request.is_xhr

@docapotamus
Copy link
Member Author

We need to re-style the flask messages so we can generate the messages from JS also without needing to scroll.

@docapotamus docapotamus modified the milestones: 0.10, 0.9 Aug 24, 2015
@docapotamus
Copy link
Member Author

Pushing back for the time being. Due to some ongoing work this it will be best for the changes currently being made to be deployed first.

@docapotamus docapotamus removed the ready label Sep 10, 2015
@docapotamus docapotamus removed this from the 0.10 milestone Dec 11, 2015
@docapotamus
Copy link
Member Author

I will add anchors to the lists also so that non-javascript users will be able to go back to where they were.

@docapotamus docapotamus added High and removed Normal labels May 18, 2016
docapotamus added a commit that referenced this issue May 29, 2016
This is one part of #56.

All upvotes/downvotes should work.

jQuery has also been updated.
@docapotamus
Copy link
Member Author

docapotamus commented May 29, 2016

The list of things to make AJAX:

  • Remove from feed
  • Delete post/comment (can't delete post via AJAX on post view, can comment though)
  • Hide alert
  • Up/down vote
  • Flag
  • Unsubscribe
  • Follow/un-follow
  • Trust/un-trust
  • Hide tip

@ghost
Copy link

ghost commented May 29, 2016

Why not add “Post something” to the list, too?

@docapotamus
Copy link
Member Author

I haven't given it much thought. There would be a lot more work to do with handling images. All posts are appended to the feed so you need to be at the top any way. I'll give it some thought 😄

@docapotamus
Copy link
Member Author

There is an issue with the current JS on votes. Once an action has been pressed the up/down vote buttons should be disabled in jQuery so they can not be repeated for that post. You will still be able to do the same action on a different post though.

May be confusing with the flash messages so I may remove them. Do the action on the page immediatley and reverse it if something goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants