Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to expand to other social networks? #20

Open
Tyree opened this issue Nov 27, 2018 · 6 comments
Open

Plans to expand to other social networks? #20

Tyree opened this issue Nov 27, 2018 · 6 comments

Comments

@Tyree
Copy link

Tyree commented Nov 27, 2018

Not an issue, per se. I have this working perfectly with Facebook. Thanks for the great work!

Are there any plans to expand this to allow integration with Instagram, Twitter, LinkedIn, etc.?

I have lots of contacts that are more business related, for example. I am connected to those people on LinkedIn, but not on Facebook.
Or maybe the ability to use the profile picture of people who aren't friends on Facebook. Perhaps we could paste in the Facebook profile url of a person if they aren't found in our friends list?

I'm sure this is almost like starting over again with the different APIs. Just curious if this was on the radar.

Thanks!

@pkoenig10
Copy link
Owner

Both of these suggestions seem like good ideas!

Providing URLs for contacts you aren't friends with should be pretty easy to support.

To support other social network, I'd like to create a provider abstract base class with the required methods. Then adding new social networks is as easy as just implementing a new provider.

@Tyree
Copy link
Author

Tyree commented Nov 27, 2018

You make it sound so simple. :-D
Thanks for the time and interest!

@Tyree
Copy link
Author

Tyree commented Apr 24, 2019

Any plans to updating this feature. At least the pasting of facebook profile URLs for people you're not friends with?
Sink is brilliant, so I hope it stays alive! :-)

@Tyree
Copy link
Author

Tyree commented Oct 30, 2019

Any update on this @pkoenig10 ? :-)

@pkoenig10
Copy link
Owner

I don't have plans to add support for other social networks at this time. This is still something that I'd like to support eventually, it's just not something I have the time or desire to work on right now.

In the meantime, you're more than welcome to fork this repository to make any changes you would like.

@Tyree
Copy link
Author

Tyree commented Oct 30, 2019

No worries. It was more the adding urls for Facebook profiles that you aren't friends with. I would be completely lost trying to add to what you've done. :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants