Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting when GitHub responds with an unsuspected status code #219

Open
burtonjc opened this issue Dec 4, 2015 · 1 comment

Comments

@burtonjc
Copy link
Contributor

burtonjc commented Dec 4, 2015

Currently, there is a white list of response codes that will be handled by Octonode. Anything outside of that list gets a generic failure message. For example, updating an issue would say "Issue update error". One of our services is getting a substantial number of these errors and we don't have any insight as to why because Octonode is swallowing GitHub's response.

Any chance that generic condition could still report the status code and body?

@burtonjc
Copy link
Contributor Author

burtonjc commented Dec 4, 2015

Also, my guess is GitHub is responding with 3xx status codes (which aren't accounted for by octonode). The request npm module follows redirects by default, so I would think it should still just work. But it does look like some redirect fixes have gone into the request module since the version octonode is using. Might be helpful to bump the request version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant