Expand accepted method names #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be 'rpc-internal' Adjusted the trigger on Procedure to accept any string on dispatch, so that if 'rpc.' methods are ever implemented, they can be activated. Added relavant test cases
|
I'd like to use method names including a separating dot. E.g.: "thing.act" This module performs great in the infrastructure i'm going to deploy! Thumbs up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC 2.0 spec says that any string is a valid method name, and I couldn't find any mention on their discussion list of an alphanumeric requirement on method names.
This patch will expand your dispatcher to accept registration on any method names, except empty string, non-string scalars, or any strings starting with 'rpc.' and on activation, accept any method names (in case you ever internally introduce "rpc." methods).
I've also included relevent test cases.
Thanks for this module, and thanks for your consideration. This is my first github/cpan pull request, I hope I'm not being improper :)