Respect $Config{ccflags} #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$Config{ccflags} must be passed to all XS compiler invocations
because they define ABI. Not doing so can lead to mismatched shared
library ABI as can bee seen on 32-bit perl with enabled 64-bit file
offsets (-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64):
armv7hl-redhat-linux-gnueabi-gcc -c -I/usr/include/pkgconf -DMY_PKGCONF_VERSION=1.3.0 -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -DVERSION=\"0.06\" -DXS_VERSION=\"0.06\" -fPIC "-I/usr/lib/perl5/CORE" LibPkgConf.c
[...]
make test
"/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- LibPkgConf.bs blib/arch/auto/PkgConfig/LibPkgConf/LibPkgConf.bs 644
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
LibPkgConf.c: loadable library and perl binaries are mismatched (got handshake key 0x8e00080, needed 0x9000080)
t/00_diag.t ...
Dubious, test returned 1 (wstat 256, 0x100)
This patch fixes Makefile.PL to respect ccflags value provided by perl.
plicease
added a commit
that referenced
this pull request
Mar 15, 2017
|
I agree those flags should be in there, but I would like to put the pkgconf flags first because Does that sound reasonable? |
plicease
added a commit
that referenced
this pull request
Mar 15, 2017
|
Sounds good.
|
|
Great! I have released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Makefile.PL does not respect perl's ccflags and that leads to broken builds on some systems. This is the fix.