Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interal link browser should start from current folder and/or should be customizable #1974

Closed
tomgross opened this issue Mar 21, 2017 · 7 comments · Fixed by #2055
Closed

Interal link browser should start from current folder and/or should be customizable #1974

tomgross opened this issue Mar 21, 2017 · 7 comments · Fixed by #2055
Labels
02 type: regression
Milestone
Plone 5.1

Comments

@tomgross
Copy link
Member

What I did:

  1. Edit a page nested in a folder structure
  2. Open dialog to insert internal link

What I expect to happen:

Search / Browsing starts at the folder the current page is located

What actually happened:

Search / Browsing starts at Root (next NavRoot)
In Plone 4.3 there were two options: Current Folder, Root and it was even custom extendable.

What version of Plone/ Addons I am using:

5.1b2-pending
@tomgross tomgross added this to the Plone 5.1 milestone Mar 21, 2017
@hvelarde
Copy link
Member

@tomgross an issue can be a bug or a regression, but not both.

@hvelarde
Copy link
Member

hvelarde commented Mar 21, 2017 •
edited

I just tested and this is a regression from the behavior found in Plone 4.3.

@fgrcon
Copy link
Member

fgrcon commented Mar 21, 2017

a bug which comes back is still a bug but also a regression (what makes it worse) , or i am totally wrong ? :-)

@fulv
Copy link
Member

fulv commented Mar 21, 2017 via email

@hvelarde
Copy link
Member

hvelarde commented Mar 22, 2017 •
edited

a regression is a bug (or a different behavior) introduced (or reintroduced) due to a refactor like in this case; it's something that should not happen if we have tests for a specific use case.

@paskyorg
Copy link

I get the same behaviour with Plone 5.0.4. Anyone know if there is a plan to correct it?

thet added a commit to plone/plone.app.widgets that referenced this issue May 19, 2017
@thet
Related items widget options changes
6c5cc6c 
- Let the browsing/searching start path be the current context if its folderish or a level up.
- Include the ``contextPath`` option to exclude the current context from selection.
- Include the ``favorites`` option with the current context and the navigation root to quickly jump to these paths.
- Clean up obsolete options.
Fixes plone/Products.CMFPlone#1974
thet added a commit that referenced this issue May 19, 2017
@thet
Align TinyMCE related items options
aeb9a48 
Let TinyMCE options for the related items widget be generated by ``plone.app.widgets.utils.get_relateditems_options``.
This aligns the options to how the related items widget is used elsewhere.
Fixes #1974
This was referenced May 19, 2017
Merged
Merged
@thet
Copy link
Member

thet commented May 19, 2017

These issue is among others addressed here:

#2055
plone/mockup#765
plone/plone.app.widgets#159

thet added a commit to plone/plone.app.widgets that referenced this issue May 22, 2017
@thet
Related items widget options changes
2639986 
- Let the browsing/searching start path be the current context if its folderish or a level up.
- Include the ``contextPath`` option to exclude the current context from selection.
- Include the ``favorites`` option with the current context and the navigation root to quickly jump to these paths.
- Clean up obsolete options.
Fixes plone/Products.CMFPlone#1974
thet added a commit that referenced this issue May 22, 2017
@thet
Align TinyMCE related items options
7454344 
Let TinyMCE options for the related items widget be generated by ``plone.app.widgets.utils.get_relateditems_options``.
This aligns the options to how the related items widget is used elsewhere.
Fixes #1974
thet added a commit that referenced this issue May 22, 2017
@thet
Align TinyMCE related items options
c083075 
Let TinyMCE options for the related items widget be generated by ``plone.app.widgets.utils.get_relateditems_options``.
This aligns the options to how the related items widget is used elsewhere.
Fixes #1974
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue May 23, 2017
@agitator
[fc] Repository: plone.app.widgets
451e0eb 
Branch: refs/heads/master
Date: 2017-05-22T14:54:00+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.widgets@2639986

Related items widget options changes
- Let the browsing/searching start path be the current context if its folderish or a level up.
- Include the ``contextPath`` option to exclude the current context from selection.
- Include the ``favorites`` option with the current context and the navigation root to quickly jump to these paths.
- Clean up obsolete options.
Fixes plone/Products.CMFPlone#1974

Files changed:
M CHANGES.rst
M plone/app/widgets/tests/test_utils.py
M plone/app/widgets/utils.py
Repository: plone.app.widgets
Branch: refs/heads/master
Date: 2017-05-23T13:06:49+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: plone/plone.app.widgets@b0fa4b4

Merge pull request #159 from plone/thet-relateditemsoptions

Related items widget options changes

Files changed:
M CHANGES.rst
M plone/app/widgets/tests/test_utils.py
M plone/app/widgets/utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 type: regression
Projects
None yet
Milestone
Plone 5.1
Development

Successfully merging a pull request may close this issue.

Align TinyMCE related items options plone/Products.CMFPlone
6 participants
@thet @tomgross @hvelarde @fulv @fgrcon @paskyorg