Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Tinymce 4.6.1 #764

Closed
wants to merge 3 commits into from
Closed

Include Tinymce 4.6.1 #764

wants to merge 3 commits into from

Conversation

frapell
Copy link
Sponsor Member

@frapell frapell commented May 19, 2017

No description provided.

@thet
Copy link
Member

thet commented May 19, 2017

@frapell there are test failures - can you address them?
IIRC for tinymce inline to work, some TinyMCE API calls are made. Maybe something has changed here? (as it fails for form saving)

@frapell
Copy link
Sponsor Member Author

frapell commented May 22, 2017

I Tried to find why this is happening, but couldn't... I created a ticket for tinymce in tinymce/tinymce#3674

In the meantime, I created a pull request for getting tinymce 4.5.6 #766 until I can figure out what's going on with 4.6.1, I will do the needful for CMFPlone

@frapell
Copy link
Sponsor Member Author

frapell commented May 23, 2017

Not quite sure what's going on... the guy from tinymce/tinymce#3674 showed me in http://fiddle.tinymce.com/CQfaab that by doing:

tinymce.activeEditor.setContent('foobar');
tinymce.activeEditor.save();
console.log($('textarea').val());

it does work fine, and the content is set on the textarea, however, from the test, I do:

tinymce.tiny.setContent('<p>foobar</p>');
tinymce.tiny.save();
$el.val()

And I get empty string...

@frapell frapell mentioned this pull request Feb 28, 2018
@thet
Copy link
Member

thet commented Apr 26, 2018

We already have 4.7.6 since #832
Closing this.

@thet thet closed this Apr 26, 2018
@thet thet deleted the tinymce_4.6.1 branch April 26, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants