Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we keep the not-production-ready disclaimer? #156

Open
pnicolli opened this issue Mar 9, 2021 · 2 comments
Open

Should we keep the not-production-ready disclaimer? #156

pnicolli opened this issue Mar 9, 2021 · 2 comments

Comments

@pnicolli
Copy link
Contributor

pnicolli commented Mar 9, 2021

I see that we have a disclaimer at the beginning of the readme that states that this image is not viable for production.
Is this still a thing?

I've started using this in production both with simple docker-compose and full-fledged kubernetes and it's working. It's a rather fresh deployment so only time will tell, but so far I'm happy with the result. Of course it needed some proper configuration, but I'm actively using this image and only defining env vars and, in a single scenario, a custom entrypoint just to add an automatic postgres waiting script at the startup.

I mean, there's room for improvement for sure, but I am afraid that adoption will be slowed down by such a statement.

Do you see any blocker in using this for production?
If yes, I'd be happy to hear that, since that would mean I could have something to deal with that I did not think about 😬
If not, I would suggest removing the statement.

Any thoughts?

@avoinea
Copy link
Sponsor Member

avoinea commented Mar 9, 2021

The idea was not to encourage people to use this image directly in production with the ADDONS environment variable and all the other env variables that trigger re-build within Docker container.

Your production Docker image should always be in a stable/immutable state, non-dependent on pypi (or any other repo) being up-and-running.

@avoinea
Copy link
Sponsor Member

avoinea commented Mar 9, 2021

Anyway, I agree that we can remove the warning from the front-end README as Sven took care and added it everywhere else where it is relevant 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants