Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hook #23

Open
svx opened this issue Feb 22, 2016 · 0 comments
Open

pre-commit hook #23

svx opened this issue Feb 22, 2016 · 0 comments
Assignees

Comments

@svx
Copy link
Member

svx commented Feb 22, 2016

Currently when we do a git push, docker hub is triggered and building a new container, so far so good.

I would like to improve that:

  • test documentation before each build
  • run docker lint

With that in place we would make sure, that we always have docs without typos or broken links, our dockerfiles following best practices about a dockerfile should be written.

Since we are talking docker, this would be really easy doable with a container, there is already a container, which the docs team uses, we could easily adjust that one or use it as a basis for an own one.

With that we would get the following pipeline:

work on ct/ct-docs -> git commit -> running tests -> if OK push to dockerhub, else fix and test again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant