Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeadImage Sidebar should use BlockDataForm like the rest of the Sidebar files #5623

Open
ichim-david opened this issue Jan 14, 2024 · 3 comments · May be fixed by #5793
Open

LeadImage Sidebar should use BlockDataForm like the rest of the Sidebar files #5623

ichim-david opened this issue Jan 14, 2024 · 3 comments · May be fixed by #5793

Comments

@ichim-david
Copy link
Sponsor Member

Started as a discussion from #1577
taking https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Blocks/Video/VideoSidebar.jsx
as an example
LeadImage Sidebar should also use BlockDataForm instead passing the block data as it does
https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Blocks/LeadImage/LeadImageSidebar.jsx

@ichim-david
Copy link
Sponsor Member Author

ichim-david commented Jan 20, 2024

@ichim-david can I work on this issue?

Hey, I am working on this already

@Manas-Kenge and @ayush4345 it seems both of you haven't read and followed the docs
https://6.docs.plone.org/contributing/first-time.html

@ayush4345 why are you working on this issue?
Let's say you don't have permission to be assigned to the issue, you should still make a comment on the
ticket so that other people know that you want to work on this ticket and that doesn't mean asking if you
could work but to spend time learning how Volto works and ensuring that if you want to create a pull request
with your fix, it is valid and follows the quality criteria set by the needs for testing, linting, news entry and everything
needed for a proper pull request and then to say you want to work on an issue because you have the required knowledge to work on the issue.

I believe that all of you newcomers are rushing way too much to take on issues without knowing the subject at
hand first.
It's as if you've never swim but you want to swim a marathon all of a sudden.

Want to work with something?
Start with something easy first, an issue that has the easy label
41 lvl: easy

Want to help?
Look at the tickets where help is asked as long as you have the knowledge to help
31 needs: help

What you shouldn't do is what you are doing right now which is to step on each other's toes
about working on something without having the know-how.

Do you want to contribute to open-source? Then be a good open-source citizen and follow
the needed steps for proper contributions otherwise you are just wasting your time and ours
when we could all do more productive things with the most limiting thing we all have, which is
our time.

@ayush4345
Copy link

Ok, sorry @ichim-david I think I have misunderstood some things. I will take care of it next time. Just one clarification, I can work on this, right ?

Like right now, I am exploring and trying to understand the codebase along with trying to fix this issue as I am aware of this tech stack.

@ichim-david
Copy link
Sponsor Member Author

Ok, sorry @ichim-david I think I have misunderstood some things. I will take care of it next time. Just one clarification, I can work on this, right ?

Like right now, I am exploring and trying to understand the codebase along with trying to fix this issue as I am aware of this tech stack.

@ayush4345 I think you should understand the codebase first and then try to solve any of the issues from Volto.
If you don't understand the stack and you just want to solve a problem out of some desire to practice programming skills your work will be subpar because you haven't used the product and don't know how it functions.

Nothing is stopping you from working on this issue but if you really want to contribute to this project you should do it after you find a use case for using the product in the first place and then after you use and you understand you can go about wanting to fix things.

If you learn to use react you have to learn the framework, work it it, discover some bug that hits you and then you might decide to work on fixing it not just going about fixing react without knowing the framework code.

@plone plone deleted a comment from Manas-Kenge Jan 20, 2024
@plone plone deleted a comment from ayush4345 Jan 20, 2024
@plone plone deleted a comment from ayush4345 Jan 20, 2024
@Manas-Kenge Manas-Kenge linked a pull request Feb 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants