New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeadImage Sidebar should use BlockDataForm like the rest of the Sidebar files #5623
Comments
@Manas-Kenge and @ayush4345 it seems both of you haven't read and followed the docs @ayush4345 why are you working on this issue? I believe that all of you newcomers are rushing way too much to take on issues without knowing the subject at Want to work with something? Want to help? What you shouldn't do is what you are doing right now which is to step on each other's toes Do you want to contribute to open-source? Then be a good open-source citizen and follow |
Ok, sorry @ichim-david I think I have misunderstood some things. I will take care of it next time. Just one clarification, I can work on this, right ? Like right now, I am exploring and trying to understand the codebase along with trying to fix this issue as I am aware of this tech stack. |
@ayush4345 I think you should understand the codebase first and then try to solve any of the issues from Volto. Nothing is stopping you from working on this issue but if you really want to contribute to this project you should do it after you find a use case for using the product in the first place and then after you use and you understand you can go about wanting to fix things. If you learn to use react you have to learn the framework, work it it, discover some bug that hits you and then you might decide to work on fixing it not just going about fixing react without knowing the framework code. |
Started as a discussion from #1577
taking https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Blocks/Video/VideoSidebar.jsx
as an example
LeadImage Sidebar should also use BlockDataForm instead passing the block data as it does
https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Blocks/LeadImage/LeadImageSidebar.jsx
The text was updated successfully, but these errors were encountered: