New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block chooser search is not focusable when clicked on add button #5867
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
@sneridagh I debugged this issue and in initial implementation there was autofocus but someone removed it. I am not able to pinpoint the person in gitblame. I readded it. |
@iRohitSingh it was part of this commit by @sneridagh. He did some other things with autofocus. I'm not clear what one has to do with the other. |
@stevepiercy which commit? autofocus is meh for a11y things... don't know if that had to be with the removal. /cc @ichim-david |
@sneridagh I am in favor of adding the autofocus back as the short version. You've probably read something similar to this mention https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autofocus#accessibility_concerns. For us since it focuses it on the search input if you hit tab you will get to the other block items from the popup which |
@sneridagh I can't find it now. I may have been mistaken. |
Fix #5866
Screen.Recording.2024-03-11.at.8.36.17.PM.mov