Fix for compiling python interface on Mac OS 10.14 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd higher. Sets the deployment target to 10.9 when compiling on version 10.9 and above. The fix is taken from https://github.com/pandas-dev/pandas/pull/24274/files
|
Should we add to the changelog something about this change/fix? Also, I have seen that line 44 (old, 55 new) is marked as changed due to some whitespace. Should I try to do something about that? |
Codecov Report
@@ Coverage Diff @@
## v2.5 #445 +/- ##
==========================================
+ Coverage 83.68% 83.69% +<.01%
==========================================
Files 560 560
Lines 40798 40798
==========================================
+ Hits 34143 34144 +1
+ Misses 6655 6654 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for compiling python interface on Mac OS 10.14, issue #443.
Sets the deployment targetfor python to 10.9 when compiling on version 10.9 and above.
The fix is based on https://github.com/pandas-dev/pandas/pull/24274/files
I have tested the changes on MacOS 10.14 and 10.12 and everything seems fine. I have also done the extended regtests (https://travis-ci.org/valsson/plumed2/builds/496552207) and everything appears fine, apart from the allowed failures (one of the Mac OS tests hangs).
Target release
I would like my code to appear in release 2.5
Type of contribution
Copyright
Tests