Fix underscores #449
Merged
Fix underscores #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to me |
|
Actually in 2.6 I would remove the - version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds aliases using "_" instead of "-" (see #435).
I would like to merge this on branch 2.4 before we release v2.4.5.
I think using only characters in
[A-Za-z0-9_]has some advantage, since it means that all actions/keywords can be valid C++/Python identifiers. In the future we might decide to disable names not matching this pattern. Merging this change now would allow for better backward compatibility.Please let me know if there is any objection to this merge. Thanks!
@gtribello @jpazurikova