Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--enable-rpath also use to PREFIX/lib #767

Closed
wants to merge 1 commit into from

Conversation

EricDeveaud
Copy link

Description

when configure --enable-rpath --prefix=/non/standard/location build does not set RPATH to PREFIX/lib
that brings the following error while installed

rpm_maker:plumed/plumed-2.7.2 > plumed -h 
plumed: error while loading shared libraries: libplumedKernel.so: cannot open shared object file: No such file or directory

the follwoing diff add PREFIX/lib to the rpath

Target release

plumed-2.7.2

regards
Eric

@codecov-commenter
Copy link

Codecov Report

Merging #767 (a722835) into master (41ceef4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         594      594           
  Lines       48335    48335           
=======================================
  Hits        41460    41460           
  Misses       6875     6875           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ceef4...a722835. Read the comment docs.

@GiovanniBussi
Copy link
Member

Thanks! Notice that the right path is $libdir.

I fixed this in master and not in 2.7 since I am not sure it is really a bug fix, rather a preference. If you are aware of some other code following this convention I am happy to backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants