Fix sum_hills overflows when doing projections #823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am trying to resolve a problem of sum_hills with overflow in exponential when projecting a grid to lower dimension.
I cc people that might be familiar with that part of the code: @carlocamilloni @gtribello @valsson. I noticed that Omar has a copy of this code in ves module, maybe he wants to update it as well.
Changes I did:
beta*v
seen seen so farAs you can see in the regtest, the aim is to be able to integrate a free energy with very large values (note that kBT is very low (0.01)). With the current master branch, the resulting fes.dat would look like this:
With the fix, it looks like this
All current regtests are not affected.
I think this is a bug fix, so I would merge it to v2.8 and then even check if I can backport to v2.7.
Target release
I would like my code to appear in release v2.8 (possibly v2.7)