Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: avoid non-portable test == operator #841

Closed
wants to merge 1 commit into from

Conversation

drhpc
Copy link

@drhpc drhpc commented Jul 8, 2022

The single = works as well and also with shells other than bash
and friends.

Description
Target release

I would like my code to appear in release XXXXX

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

The single = works as well and also with shells other than bash
and friends.
@drhpc
Copy link
Author

drhpc commented Jul 8, 2022

Also … I got a change in the pipeline where I need to ensure that the RPATH setting reaches the plumed main binary. It touches configure, too, so it would be nice if this simple one here could be merged first.

@GiovanniBussi
Copy link
Member

Thanks! This looks like a portability fix, so I plan to backport it (manually) to version 2.7. Does it make sense?

Regarding this point, can you check if this is already fixed? I think I fixed it in v2.8 branch, so that it will end up in v2.8.1 (not released yet, though).

@carlocamilloni
Copy link
Member

@GiovanniBussi is this or part of it still valid?

carlocamilloni added a commit that referenced this pull request Sep 19, 2022
@carlocamilloni carlocamilloni mentioned this pull request Sep 19, 2022
7 tasks
GiovanniBussi added a commit that referenced this pull request Sep 19, 2022
Same as 3f71057 for v2.8
GiovanniBussi added a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants