Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions #16

Open
snellingio opened this issue Sep 3, 2019 · 1 comment
Open

Transitions #16

snellingio opened this issue Sep 3, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@snellingio
Copy link

Unsure if this is supported, it might already be by adding css classes.

If so, we should document how to use them. I can see wanting to transition both the content (think counter) and the content area (think modal)

@johnholdun
Copy link
Contributor

Transitions are, in theory, supported by the lifecycle-based classes that Trimmings adds while fetching and replacing content, but I honestly haven't done too much experimentation here to confirm that what's offered is sufficient for a broad set of desired effects.

I hope to either prove that it's sufficient, or add additional descriptive classes to affected DOM nodes, soon! Adding the good first issue label here because I'd love to see someone else pick this up and try to produce some examples of good transitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants