New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING, merge after 4.0.1 - (#4222) - remove idb-alt plugin #4222
Conversation
Oh another reason to get rid of it: it increases the build time both in Travis and when you run |
So tentative + .5 I have always seen the levelalt adapters as experimental, I dont think they are useful alternatives at the moment but its nice to see that they work. I would be happier maybe emphasizing them in the docs and keeping them in travis. But not hugely fussed either way |
If a moment comes where the idb-alt adapter is considered actually useful, re-enabling it shouldn't be that hard. Worst case scenario, a few bug fixes in either of the projects. The interface isn't going away. But spending time on it in the meantime? Naah. I think removing it is the right decision at the moment. |
Surprisingly, I'm seeing the Hoodie folks using the As for For |
forgot to remove |
Ok lets do this - 427efbc |
This reverts commit 427efbc.
I am fairly certain nobody is using this. I think it was
a nice test case for a long time, and especially served
to convince us we weren't crazy when MemDOWN and LocalStorageDOWN
kept failing the tests, but level.js passed them just fine.
However, I think it's pretty clear by now that we're not going
to replace the
idb
adapter with this; it browserifies too large,there are too many PouchDB-specific optimizations in the current
idb adapter, and we don't have a reasonable migration plan. So
I think we should just drop support.
This will require a major version release, so we can wait until after 4.0.1
to merge.