(#4313) - fix options usage within http adapter #4313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks sensible, thanks for catching, will see what CI says now |
| @@ -63,7 +63,7 @@ function preprocessAttachments(doc) { | |||
|
|
|||
| // Get all the information you possibly can about the URI given by name and | |||
| // return it as a suitable object. | |||
| function getHost(name, opts) { | |||
| function getHost(name/*, opts*/) { | |||
|
Awesome green run :) not sure whats up with the allowed failures but its probably nothing, restarted. If you want to address the nit and squash these up with the right commit message, I dont think tests are absolutely required for this change, but I am mostly not committing already in case you do want to add them. |
* remove unneeded usage of opts within getHost * don't mutate input ajax options
omsmith
force-pushed
the
http-opts-cleanup
branch
from
270e232
to
f08e8b9
Compare
omsmith
changed the title
|
removed the commented param, squashed, and reworded |
daleharvey
pushed a commit
that referenced
this pull request
Sep 13, 2015
* remove unneeded usage of opts within getHost * don't mutate input ajax options
|
Awesome, thanks - d9e9726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daleharvey noticed some oddities in the diff from 3c964ad
1st commit:
getHostno longer usesopts. So in particular, we definitely dont need to clone them. Still passesoptstogetHostFnin case the passed in implementation uses it.2nd commit: after the change, the input
opts.ajaxis being modified within theif (opts.auth || host.auth)so this just moves thecloneearlierCan fix-up commit messages / add regression test for the second case, but was able to just do this quick to get it in front of you