Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessarily saving revisions array to metadata #8938

Open
keijokapp opened this issue Apr 25, 2024 · 0 comments
Open

Unnecessarily saving revisions array to metadata #8938

keijokapp opened this issue Apr 25, 2024 · 0 comments

Comments

@keijokapp
Copy link

I've been developing a FoundationDB adapter. FoundationDB has a hard limit on key and value lengths, so 4204 respect revs_limit brought out this issue.

It seems that _revisions passed into bulkDocs is used only to create an initial revision and tree but is then moved to document's metadata and saved to document store. The property doesn't seem to be used for anything else and removing that before returning from parseDoc doesn't break any tests. What's worse is that this array does not get reduced to revs_limit in a same way as revision tree does. So it's just there taking up space.

I'd be willing to make a PR but it seems there are also other reserved properties that are not used at all but still saved (eg. deleted_conflicts) and I'm not sure what the intentions are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant