System-wide iPad gestures produce a click event on activation

[frenzibyte]

There is a gesture in my iPad allowing me to take screenshots by swiping from the bottom left corner. On osu!, that position of activating the gesture conflicts with the back button, resulting in the following:

trim.E94E67DC-4B18-41BB-94C9-DB286ABBE52D.MOV

It seems that whenever the OS acknowledges the gesture or proceeds with the screenshot, the "finger" is released and the game incorrectly handles that as a click rather than it being cancelled.

[gadielisawesome]

This does do the exact same thing for me.

[Susko3]

Since SDL is used for input handling on iOS, and SDL_TouchFingerEvent doesn't seem to have a notion of canceling an event. This should be reported first to upstream, preferably with verbose SDL_HINT_EVENT_LOGGING enabled.

I know that Android has a similar notion of canceling motion events. And the same thing could apply to desktop: the window loosing focus when a mouse button is held (via alt-tab or another app coming to the foreground).

Not sure what's the best way to implement in o!f. On a high level, if a touch up input is cancelled, it shouldn't fire a ClickEvent. The touch/mouse up event should still fire so it doesn't get stuck in a down state.

[frenzibyte]

A good start would be to implement a "Cancelled" state to button input events, which "MouseButtonEventManager" uses as an indicator to not fire a click event while still firing a mouse up event.

That would also replace an existing flag in that class that works similarly (used in hold-for-right-click logic).