Allow partial enumeration of directory entries #6083
Conversation
| { | ||
| // Don't fail enumeration if we fail getting attributes for a single entry | ||
| Logger.Log($"Directory {directoryName} is inaccessible", LoggingTarget.Information, LogLevel.Debug); | ||
| } | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
To keep in line with the intentions of the method, I think it should return false (like it previously did) if enumerating all directories failed. I.e. if the inner catch got triggered, and items.Count == 0, false should be returned.
Empty directories should return true as it currently works.
If you opt for IgnoreInaccessible I'm fine with returning true even if all the entries couldn't be opened.
There was a problem hiding this comment.
You're right, I overlooked the scenario you described.
| @@ -204,10 +205,19 @@ protected virtual bool TryGetEntriesForPath(DirectoryInfo path, out ICollection< | |||
|
|
|||
| try | |||
| { | |||
| foreach (var dir in path.GetDirectories().OrderBy(d => d.Name)) | |||
There was a problem hiding this comment.
Looking into this, I found an EnumerateDirectories(String, EnumerationOptions) overload that can take in EnumerationOptions, which has the option IgnoreInaccessible -- exactly what you're looking for (there's also AttributesToSkip that could be used for hidden items).
The same should also apply to FileSelector.
There was a problem hiding this comment.
Unfortunately EnumerateDirectories, even with IgnoreInaccessible, throws an exception. I've tried many of the other overloads that allow ignoring certain failures with no success; enumerating using a string of the path really was a last-resort.
2023-12-27_04-41-41.mp4
Closes #6082
Due to
DirectoryInfo.GetDirectoriespre-populating some DirectoryInfo properties,TryGetEntriesForPathmay fail and returnfalsedespite there being valid subdirectories for the user to safely pick.