Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CancellationToken should probably always be present in BDL calls #6157

Open
peppy opened this issue Jan 29, 2024 · 0 comments · May be fixed by #6159
Open

CancellationToken should probably always be present in BDL calls #6157

peppy opened this issue Jan 29, 2024 · 0 comments · May be fixed by #6159
Labels
area:dependency-injection

Comments

@peppy
Copy link
Sponsor Member

peppy commented Jan 29, 2024

Currently it's nullable, which makes usage a bit annoying. Should always be cached as default if not present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dependency-injection
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow value types to be cached and injected as dependencies smoogipoo/osu-framework
1 participant
@peppy