Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeatmapStore grows indefinitely (probably needs some kind of expiry logic) #143

Open
peppy opened this issue Aug 24, 2023 · 1 comment · May be fixed by #262
Open

BeatmapStore grows indefinitely (probably needs some kind of expiry logic) #143

peppy opened this issue Aug 24, 2023 · 1 comment · May be fixed by #262

Comments

@peppy
Copy link
Sponsor Member

peppy commented Aug 24, 2023

When running in lower memory scenarios this could become an issue.

It's actually caused production failures after running for several weeks. The failures may only occur on scores which haven't had a beatmap cached, meaning the queue processor doesn't see enough consecutive errors to quit out, and causing intermittent score processing failures for some users.
@peppy peppy changed the title BeatmapStore grows indefinitely BeatmapStore grows indefinitely (probably needs some kind of expiry logic) Aug 24, 2023
@smoogipoo
Copy link
Contributor

In cases like this (and osu-beatmap-difficulty-lookup-cache), I tend to gravitate to wanting to use one of the .NET caching extensions (https://learn.microsoft.com/en-us/dotnet/core/extensions/caching) that both have some concept of "size".

It might be an interesting venture to see if that could be used for more of these k8s components...

@tsunyoku tsunyoku linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor BeatmapStore to use MemoryCache tsunyoku/osu-queue-score-statistics
2 participants
@peppy @smoogipoo