Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios 13 support #20

Open
zainesmail opened this issue Nov 4, 2019 · 19 comments
Open

ios 13 support #20

zainesmail opened this issue Nov 4, 2019 · 19 comments

Comments

@zainesmail
Copy link

How do I compile this for it to be supported in ios 13?

@jwogan5
Copy link

jwogan5 commented Nov 18, 2019

I just tried the version 2.0.0 for iOS and the app compiles fine but just hangs at startup

@jwogan5
Copy link

jwogan5 commented Nov 18, 2019

Dyld Error Message:
Library not loaded: @rpath/libswiftAVFoundation.dylib
Referenced from: /Users/USER/Library/Developer/CoreSimulator/Devices/FE3824A0-D493-4838-A181-51871B86AC40/data/Containers/Bundle/Application/DCEA267B-4343-4CEF-A615-49EA73566EFB/TraderTraxx.app/Frameworks/TiImagepicker.framework/TiImagepicker
Reason: image not found

@zainesmail
Copy link
Author

Which titanium SDK are you using? @jwogan5

@jwogan5
Copy link

jwogan5 commented Dec 6, 2019

I was able to get this working today. I had to build it myself and turn on the flag in xcode to add swift libraries and then I had to also embed the frameworks in xcode. After that it finally built the app and ran fine.

@Yazany6b
Copy link

@jwogan5 could you please send me the builded module I'm facing same issue here :) :)

@jwogan5
Copy link

jwogan5 commented Dec 19, 2019

Sure, I didn't want some of the functionality in the module such as ability to take photos or videos and the add filters to photos section after the initial selection of the photos, so in my module I added the code to remove those.

Do you want the module as I have which really is just an image picker or do you want the full module with my changes removed?

@jwogan5
Copy link

jwogan5 commented Dec 19, 2019

This is my module stripped down to just the image picker part.

https://github.com/jwogan5/jwogan5.github.io/blob/master/ti.imagepicker-iphone-2.1.0.zip

If you want full module let me know?

@Yazany6b
Copy link

@jwogan5 Thanks alot I need only the image picker functionality nothing else, I'm using the module you provided and its working as expected, Thanks Again.

@Yazany6b
Copy link

@jwogan5 When trying to distribute the app for test flight it shows the following error
Screen Shot 2019-12-21 at 4 58 48 AM

@jwogan5
Copy link

jwogan5 commented Dec 22, 2019

@Yazany6b

I figured the issue out and built a new module. This one will upload to the store as I uploaded my app to the store to test it.

I also renamed the version to 2.0.1 so run the following before installing the module.

rm -rf ~/home/Library/Application Support/Titanium/modules/iphone/ti.imagepicker/2.1.0

The new module is :
https://github.com/jwogan5/jwogan5.github.io/blob/master/ti.imagepicker-iphone-2.0.1.zip

@Yazany6b
Copy link

@jwogan5

Thanks it worked thank you very muuuuuch, by the way I have developed about 16+ mobile apps using titanium if you needed any help with anything please contact me though my email yazan@immacomma.com, Thanks a lot again.

@jwogan5
Copy link

jwogan5 commented Jan 5, 2020

@Yazany6b

I just built a new 2.0.2 version of the module that has the newest releases of all the included frameworks. This includes a fix for dark mode support where when in dark mode the close text is visible instead of black text on a black background. Let me know if you need it.

@AnthonyNjuguna
Copy link

@jwogan5 I need it 🙂
Do you have a public repo with your code?

@macasfaj
Copy link

I need it too! Thanks 😊

@jwogan5
Copy link

jwogan5 commented Feb 21, 2020

@ndynamite
Copy link

@jwogan5 Thanks for the complied version. Would you be willing to share your source code?

@jwogan5
Copy link

jwogan5 commented Mar 3, 2020

@ndynamite

Basically, all I did was hardcode some values in the TiImagePickerModule.swift file because I wanted it to behave a certain way without making code changes in the main project and creating a PR. If people want these changes I could make a PR for it. I also downloaded carthage and got all that setup so that I could get the newest versions of the library frameworks to work. The current ones in this module did not support the higher versions of swift which is why the module did not work for me. Once I was able to get the newest frameworks in the module everything worked. The zip file I put up above if unzipped you will have the newest versions of the frameworks. You can just take those 3 files and place them into the platform folder and build the module for yourself without my hardcoded changes.

I did not want to have the ability to take photos or filters. I basically just wanted a library image picker. But again just download the current project from this repo. Switch out the platform 3 library files with the ones contained in my zip file. You will then have the most up to date library files in the platform folder. You can then build the project and everything will work.

These are my hardcoded changes in the main swift file.

config.showsPhotoFilters = false
config.startOnScreen = .library
config.screens = [.library]
config.shouldSaveNewPicturesToAlbum = false
config.onlySquareImagesFromCamera = false
config.hidesBottomBar = true

// General (optional) config
config.library.numberOfItemsInRow = options["columnCount"] as? Int ?? 3
config.library.onlySquare = false
config.library.isSquareByDefault = false
config.library.skipSelectionsGallery = true

@ndynamite
Copy link

@jwogan5

Thank you for the detailed information Jason! That is very helpful.

I need to make a couple of modifications to TiImagePickerModule.swift myself so I will follow your advice and copy the 3 library files.

Thanks again!

@caspahouzer
Copy link

Then you know how to disable the zoomed view at opening of the imagepicker? the preview images always fill the screen and are saved like that. I have to disable this option on start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants