Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a flag to show all warnings including the ignored ones? #1767

Open
bonniesimon opened this issue Mar 17, 2023 · 5 comments
Open

Is there a flag to show all warnings including the ignored ones? #1767

bonniesimon opened this issue Mar 17, 2023 · 5 comments

Comments

@bonniesimon
Copy link

Is there a way to see the ignored warnings without removing their entry from the brakeman.ignore file?

I wanted to see the ignored cases in the cli itself. Is that currently possible?

@presidentbeef
Copy link
Owner

Ignored warnings are included in the JSON output (e.g. brakeman -f json).

That's the only good way right now.

@bonniesimon
Copy link
Author

Would love to have a flag that would show all the warning including the ignored warning. I would love to contribute to that feature. Let me look into it.

But before that just give me your thoughts on such a flag.

@presidentbeef
Copy link
Owner

What's the desired behavior you are looking for?

  1. Ignore the ignore file
  2. Show all warnings, but ignored warnings are in a separate section or otherwise marked
  3. Show all warnings, but only return a non-zero exit code for unignored warnings

@bonniesimon
Copy link
Author

I think 2. would be good. I'm not sure what 3. means.

@presidentbeef
Copy link
Owner

Works for me. --show-ignored or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants