Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Change run_at property of privly.js? #127

Open
breezewish opened this issue Jun 3, 2015 · 3 comments
Open

Change run_at property of privly.js? #127

breezewish opened this issue Jun 3, 2015 · 3 comments

Comments

@breezewish
Copy link
Member

Currently manifest.json doesn't specify a run_at property for privly.js, which means it will run at document_idle.

In poor network conditions, for example, while loading a script blocks(defers) the document_end and document_idle, privly.js injection will not be executed at the moment while the content has already been shown.

https://www.dropbox.com/s/cv5if1v2pnujch3/privly_2.mp4?dl=0

Change run_at to document_start may prevent this issue.

@smcgregor
Copy link
Member

I experimented with this a while back and it caused more issues than it solved for me. Can you turn it on for yourself and see if this is still the case? I'll re-evaluate if you continue to support the change after a week.

@breezewish
Copy link
Member Author

I think there are more than just change the manifest.json. I will check the code.

@smcgregor smcgregor added Minor and removed Normal labels Sep 25, 2015
@smcgregor
Copy link
Member

Downgraded to minor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants