Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booleans that rely on redacted are misleading. #284

Open
mattharbord opened this issue Mar 12, 2023 · 1 comment
Open

Booleans that rely on redacted are misleading. #284

mattharbord opened this issue Mar 12, 2023 · 1 comment

Comments

@mattharbord
Copy link

mattharbord commented Mar 12, 2023

HI!

Just started playing around with the API - from the closed issues and the responses I get I understand you're anonymising a lot of data. Understandable.

I wondered if this was documented anywhere more verbosely than what's in iQL?

Am I right in my understanding that fields like makers in post will now be an array of 0 for the id unless I am one of the makers (and therefore my id would be in scope for the request)?

Running this query:

query test {
  post(id: "382374") {
    comments (first: 1) {
      nodes {
        url
        user {
          isMaker
        }
        userId
      }
    }
    name
    url
    makers {
      id
    }
  }
}

The response gives me 0's for the makers - fine, I guess.

My problem is that the isMaker flag under the user in the comments nodes is false, when in reality it is true - would it be possible to use a more explicit state such as null rather than mislead?

And is the redaction a continuous work in progress? Or is the API currently stable?

Thanks!

@ztat
Copy link

ztat commented Mar 15, 2023

+1 and following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants