Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to set custom header for a HttpProxy for all routes #5576

Open
deveshk0 opened this issue Jul 24, 2023 · 7 comments · May be fixed by #5586
Open

How to set custom header for a HttpProxy for all routes #5576

deveshk0 opened this issue Jul 24, 2023 · 7 comments · May be fixed by #5586
Assignees
@deveshk0
Labels
area/httpproxy Issues or PRs related to the HTTPProxy API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.30.0

Comments

@deveshk0
Copy link

What question do you have?:
How to set custom header for a HttpProxy for all routes

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Contour version: 1,25
  • Kubernetes version: (use kubectl version): 1.26
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
@deveshk0 deveshk0 added kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jul 24, 2023
@github-actions
Copy link

Hey @deveshk0! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@sunjayBhatia
Copy link
Member

Looks like this was asked/answered on slack as well: https://kubernetes.slack.com/archives/C8XRH2R4J/p1690201051662899

@sunjayBhatia sunjayBhatia removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Jul 24, 2023
@deveshk0
Copy link
Author

@sunjayBhatia yes

As currently headers are supported either on global policy level or on each route level.
is there any plan to add support custom headers on proxy level?

@deveshk0
Copy link
Author

deveshk0 commented Jul 25, 2023 •
edited

Since Envoy support header based on virtual host, can we support this also? https://pkg.go.dev/github.com/envoyproxy/go-control-plane@v0.11.1/envoy/config/route/v3#VirtualHost

I am happy to put a PR with little bit of guidence

deveshk0 added a commit to deveshk0/contour that referenced this issue Jul 25, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
1d25edf 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
@deveshk0 deveshk0 linked a pull request Jul 25, 2023 that will close this issue
Open
deveshk0 added a commit to deveshk0/contour that referenced this issue Jul 26, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
563a21d 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/httpproxy Issues or PRs related to the HTTPProxy API. and removed kind/question Categorizes an issue as a user question. labels Jul 28, 2023
@skriss skriss added this to the 1.27.0 milestone Jul 28, 2023
@deveshk0
Copy link
Author

deveshk0 commented Oct 4, 2023

@skriss PR is already open for this, can someone review this ?

@skriss
Copy link
Member

skriss commented Oct 4, 2023

Ack, I'll add to my review queue.

@skriss skriss modified the milestones: 1.27.0, 1.28.0 Oct 23, 2023
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
65b76c0 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
10534bd 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
34f4a9b 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
bcac4eb 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
27e4ac7 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Dec 27, 2023
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
209b2d6 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 16, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
5e96b1c 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 16, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
dcd27f5 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 16, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
d171f69 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 17, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
af00cea 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 17, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
4a504c1 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 17, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
bec1c98 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Jan 17, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
da12bda 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
@sunjayBhatia sunjayBhatia modified the milestones: 1.28.0, 1.29.0 Feb 1, 2024
@sunjayBhatia
Copy link
Member

Apologies, we got a bit behind reviewing the PR for this issue, bumping to 1.29.0

deveshk0 added a commit to deveshk0/contour that referenced this issue Mar 6, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
6b4ed1f 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Mar 6, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
27739ff 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Mar 6, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
9993502 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
deveshk0 added a commit to deveshk0/contour that referenced this issue Mar 26, 2024
@deveshk0
internal/contour: Add Support for custom headers on HTTPProxy level
86b578c 
Introduces support for request and repsonse headers on http proxy level

Fixes: projectcontour#5576
Signed-off-by: Devesh Kumar <vrshu112@gmail.com>
@skriss skriss modified the milestones: 1.29.0, 1.30.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deveshk0 deveshk0

Labels
area/httpproxy Issues or PRs related to the HTTPProxy API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: In Progress
Milestone
1.30.0
Development

Successfully merging a pull request may close this issue.

internal/contour: Add Support for custom headers on HTTPProxy level deveshk0/contour
3 participants
@skriss @sunjayBhatia @deveshk0