Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser swallows leading whitespace after indented placeable #286

Open
RumovZ opened this issue Nov 9, 2022 · 2 comments
Open

Parser swallows leading whitespace after indented placeable #286

RumovZ opened this issue Nov 9, 2022 · 2 comments
Labels
bug good first issue Want to help? Those are great bugs to start with! help wanted We need help making decisions or writing PRs for this.

Comments

@RumovZ
Copy link
Contributor

RumovZ commented Nov 9, 2022

In this fixture, the leading whitespace in front of "four" is preserved as expected:

key12 =
{ "." }
    four

However, with normalized indentation, it is not:

key12 =
    { "." }
        four

This is wrongly parsed to the same AST as this:

key12 =
    { "." }
    four
@gregtatum gregtatum added bug help wanted We need help making decisions or writing PRs for this. good first issue Want to help? Those are great bugs to start with! labels Nov 10, 2022
@gregtatum
Copy link
Member

I'm tentatively marking this as a good first issue since it will probably be a relatively small patch, but you should probably like parsers if you want to take this one.

@RumovZ
Copy link
Contributor Author

RumovZ commented Nov 10, 2022

When this is fixed, crlf.ftl may be removed from the IGNORE_LIST in fluent-syntax/tests/serializer_fixtures.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Want to help? Those are great bugs to start with! help wanted We need help making decisions or writing PRs for this.
Projects
None yet
Development

No branches or pull requests

2 participants