Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first-class support for target platform #66

Open
nickwalkmsft opened this issue Mar 7, 2017 · 2 comments
Open

Add first-class support for target platform #66

nickwalkmsft opened this issue Mar 7, 2017 · 2 comments

Comments

@nickwalkmsft
Copy link
Contributor

KuduScript currently has no first-class support for "target platform", or (alternatively) a couple of platform-related options: automatic modification of directory separator (forward slash vs. backslash) and automatic modification of line endings in the generator script (CRLF vs LF).

Some decisions are based on the type of script being generated, and some are based on the platform that KuduScript is running on (as opposed to the platform the resulting script will run on).

Not sure exactly what the result would look like yet.

@mattmazzola
Copy link

mattmazzola commented Mar 3, 2019

I believe this issue is related to a problem I recently had.

From the docs
It suggests to run kuduscript -y --node
Because I was on Windows it generated a deploy.cmd file, but I was deploying to "App Service for Linux" so it couldn't use the deploy.cmd and it failed. The was very difficult to diagnose for me because I thought I was following the directions.

I would suggest to add a --platform option like:
kuduscript -y --node --platform=linux

In this case if overrides the detection of OS and forces the right file deploy.sh to be generated.

Or if the authors prefer not for the options to take values then it can specify linux directly.
kuduscript -y --node --linux

It should also update the docs to explain this issue of deploying to an environment that different OS than your current development machine and when to use these options.

@hamzahik
Copy link

If you look at the code you can find the option -t or --scriptType that takes one of the following values: batch, bash, pos

The following generates a bash script (tested on Windows):

kuduscript --node -t bash -y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants