Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonfunctional in Thunderbird 60.0b9 (32-bit) Beta #64

Closed
DNIU14 opened this issue Jul 7, 2018 · 23 comments
Closed

Nonfunctional in Thunderbird 60.0b9 (32-bit) Beta #64

DNIU14 opened this issue Jul 7, 2018 · 23 comments

Comments

@DNIU14
Copy link

DNIU14 commented Jul 7, 2018

Very disappointing that it is totally nonfunctional for Thunderbird 60.0b9 (32-bit) Beta.

@ghost
Copy link

ghost commented Jul 26, 2018

Iaorana !

I confirme it' dosen't works. When i open the windows to sort, the accounts are not extracted:

image

Thanks
François

@schneeschmelze
Copy link

schneeschmelze commented Aug 6, 2018

Same here on TB 60.0/macOS 10.13.6. :(

@jgato
Copy link

jgato commented Aug 7, 2018

ouuuuuuch it is a very useful addon, to better keep attention to first folders...

@Berenke
Copy link

Berenke commented Aug 7, 2018

Same error on TB60.0 32bit / Win8.1 64bit.

I have two remarks.

First there isn't the latest version on the AMO site. If I see right, the latest changes occurred about 3 months ago but on AMO site there is a version from 1st of May 2016 (I checked this in the code, there is the same situation).

Second I made a little test with the latest addon version. I saved the oldest TB before install the new, so I can get the addon's folder order settings from it. Then I installed TB 60 and addon, set the folder order to manually defined and put the old settings with Preferences > Advanced > Config Editor. Aftrer it I restarted TB and folders order was I got used to it. Then I checked the folder list in addon's settings, it was empty. When I close the addon's window the TB's folder order is messed up and the addon settings in the Config Editor is returned to default. I'm not a programmer but because of the above I think this is a settings saving or settings viewing error in the addon.

Beren

(Sorry for my bad English, this isn't my native language but I hope there is understandable.)

@GH-User
Copy link

GH-User commented Aug 8, 2018

Same here on TB60.0 32bit, Win7 64bit.

@gjf
Copy link

gjf commented Aug 9, 2018

Same on TB60.0 64 bit, Win 10 Pro x64.

@yan12125
Copy link

yan12125 commented Aug 9, 2018

TL;DR - @protz Please release a new version for Thunderbird 60 compatibility.


Below are my findings. First, there's a line in my terminal:

JavaScript error: chrome://tbsortfolders/content/folderPane.js, line 56: SyntaxError: missing { before function body

The line 56 of the mentioned file in extensions/tbsortfolders@xulforum.org.xpi is:

        tbsf_prefs_functions[key] = function (a,b) tbsf_sort_functions[2](tbsf_data[key][1], a, b);

This line has been fixed in 88cebfa. Above all, a new version should fix the issue.

@TCHessen
Copy link

TCHessen commented Aug 9, 2018

With this fixes in 88cebfa the extension works a bit more better, but the folder pane does not load. Maybe I find some time to fix it, but I cannot update the repository.

The line 198 in ui.js looks strange, but it is more than just a typo:

folders_tree.builderVew.addListener(some_listener);

@GH-User
Copy link

GH-User commented Aug 9, 2018

I can verify @TCHessen that it is still not working with this fix.

@biggybean
Copy link

Backing this - Win10 Home 64bit, TB 60.0 32bit

@Berenke
Copy link

Berenke commented Aug 9, 2018

@TCHessen: I tried to change "builderVew" to "builderView" or simple "builder" - I thought it's just a spelling mistake. Not fixed anything but made more errors.

@TCHessen
Copy link

The main problem is that (in ui.js:198) the entity folders_tree.builderView (or folders_tree.builder) is null, but in the prior version of tb not. So there are major changes in the api that need more time than just to fix a typo.

@GH-User
Copy link

GH-User commented Aug 16, 2018

Hopefully someone will find a solution because it seems that the original author doesn't work any more on this very useful addon.

@tomdess
Copy link

tomdess commented Aug 17, 2018

Not working on TB 60.0 (64-bit) Linux, any altenative add-on?

@rezeptpflichtig
Copy link

The main problem is that (in ui.js:198) the entity folders_tree.builderView (or folders_tree.builder) is null, but in the prior version of tb not. So there are major changes in the api that need more time than just to fix a typo.

pretty sure it should be folders_tree.builder
but the folders_tree is already null.
in ui.js:190 it is calling document.getElementByID("foldersTree")
but there is no such ID in the DOM.. but a folderTree
however changing that did not help either and I don't know how the folder list is eaxtly build..

@Othneios
Copy link

Othneios commented Oct 3, 2018

in the ui debugger there is an element with ID "folderTree". You got the missing "s"

@hb9tst
Copy link

hb9tst commented Oct 4, 2018

@rezeptpflichtig Indeed it doesn't help, the big issue is the removal of RDF-based trees in XUL (see comments on issue #67 for more details), so there is no easy fix and that part of the UI has to be reimplemented.

@x-ji
Copy link

x-ji commented Oct 30, 2018

Duplicate of #67? The version by @Ximi1970 at https://github.com/Ximi1970/Manually-Sort-Folders/releases seems to work.

@Gluups
Copy link

Gluups commented Nov 8, 2018

Hello, compared to the version that is (still) installed by the extensions manager, Ximi1970's version has the advantage in Thunderbird 60 to display the names of the accounts and of the folders.
Nevertheless I see no up/down buttons. It is right that this problem is mentioned in bug #67, but is there any solution ?

@Ximi1970
Copy link
Contributor

Ximi1970 commented Nov 8, 2018

Change the "Use Thunderbird's default" to "Use manually defined sort function"...

@Gluups
Copy link

Gluups commented Nov 8, 2018

Sorry about my previous message : I did not select the manual order, so it was normal there were no up/down buttons.
So, after migrating to Thunderbird 60, I did not test modifying the orders, but the aspect of the user interface seems correct.
Well, when everything is good, it can be a good idea to do a proper deployment, so that people get the correct version through the extensions manager.
I found a good version because I followed this thread.

@Gluups
Copy link

Gluups commented Nov 8, 2018

Sorry not to have been quick enough to say I found the reason ...

@protz
Copy link
Owner

protz commented Dec 16, 2018

My sincerest apologies for the long delay with this update. Various life things got in the way, not to mention my research work which is my main focus of interest these days. I am happy to announce that, in spite of it all, this addon which I created while an undergrad nearly 10 years ago just received an update that makes it compatible with Thunderbird 60! Thunderbird should update automatically in a few days, as soon as the new version is accepted. If you'd rather upgrade now:

Thanks again to @Ximi1970 for the update.

Hope this helps!

Best,

Jonathan

@protz protz closed this as completed Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests