Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User gcode breaks the graphics of sliced model #5538

Closed
KRUP85 opened this issue Dec 20, 2020 · 3 comments
Closed

User gcode breaks the graphics of sliced model #5538

KRUP85 opened this issue Dec 20, 2020 · 3 comments

Comments

@KRUP85
Copy link

KRUP85 commented Dec 20, 2020

Version

2.3.0 rc1, Windows 10 home, 20H2

When I added these two commands to gcode "before layer change", the matched model is displayed incorrectly. However, gcode is fine.

;BEFORE_LAYER_CHANGE
G92 E0.0
;LAYER:[layer_num]
;HEIGHT:[layer_z]

OK-1
OK-2
NOK-1
NOK-2
@rtyr
Copy link
Collaborator

rtyr commented Dec 20, 2020 •
edited

Reproduced with rc1. Similar to #4992.

@bubnikv
Copy link
Collaborator

bubnikv commented Jan 5, 2021

We need to check the custom G-code sections for the annotations that PrusaSlicer utilizes for its G-code viewer and refuse to slice with such custom G-code sections, or at least give a warning.

;LAYER:xxx
;HEIGHT:xxx

enricoturri1966 added a commit that referenced this issue Feb 18, 2021
@enricoturri1966
#5538 - Validation of custom g-code against gcode processor reserved …
86d7e1f 
…keywords
@bubnikv
Copy link
Collaborator

bubnikv commented Aug 6, 2021

PrusaSlicer 2.4.0-alpha1 will test for the reserved comments in all custom G-codes and such custom G-codes will not be accepted.

@bubnikv bubnikv closed this as completed Aug 6, 2021
@bubnikv bubnikv mentioned this issue Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bubnikv @rtyr @KRUP85