Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"npm install pug" leads to annoying warnings #3222

Open
Tilogorn opened this issue Mar 6, 2020 · 3 comments
Open

"npm install pug" leads to annoying warnings #3222

Tilogorn opened this issue Mar 6, 2020 · 3 comments

Comments

@Tilogorn
Copy link

Tilogorn commented Mar 6, 2020

Pug Version: 2.0.4

Node Version: v8.17.0

NPM Version: 6.14.2

I know this is not directly related to pug, but maybe you have the power to help anyways.
pug has a dependecy pug-code-gen which has a dependency constantinople which has a dependency babel-types@6.26.0.

This babel-types version depends on core-js@2.6.11 which not only produces an annyoing post-install message (discussed here) but also a deprecated warning by npm.

See the following output:

$ npm install pug
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

> core-js@2.6.11 postinstall /home/daniel/src/test/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

I am aware of the fact that pug is just the top dependency in this chain and you cannot/want not change their code base. But for two reasons you might want to overthink your dependencies or be interested to get in the touch with the responsible developers:

  1. This is no reputable output for the pug project
  2. As my project is just dependent on pug and not on core-js directly, I would have a lot cleaner logs and I would get less questions/complains/mockings by the other devs in my team when they pull and update their clones.

I am willing to create this issue in the underlaying repositories if you think I addressed you wrongly.

@Tilogorn
Copy link
Author

Tilogorn commented Mar 11, 2020

As far as I can see, this issue would be resolved with just publishing a new release of pug based on current master. Commit 201b9c7 updated constantinople to 4.0.1 which removed babel-types from the dependencies.

Just tested it by npm install constantinople@4.0.1 manually. No more deprecated warning, no more looking for a good job!

Edit: This issue addresses the same problem: #3205

@Volper212
Copy link

Is this project abandoned or what? There's been no commit since December

@Volper212
Copy link

https://www.theregister.co.uk/2020/03/26/corejs_maintainer_jailed_code_release/
Oof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants